Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_stability config into semconv_grouped_attributes #569

Open
lmolkova opened this issue Jan 24, 2025 · 1 comment · May be fixed by #588
Open

Add include_stability config into semconv_grouped_attributes #569

lmolkova opened this issue Jan 24, 2025 · 1 comment · May be fixed by #588
Assignees

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jan 24, 2025

We support exclude_stability but it's proven to be dangerous. The key scenario behind it is separating stable from non-stable signals.

exclude_stability: "experimental" is more prone to bugs (e.g. excluding "development" would bring a bunch of rc attributes and does not really make sense). What happened in open-telemetry/semantic-conventions#1777 is that we let attribute without stability in and it appeared as stable in Python and C++ since it was not experimental either.

If we used include_stability: ["stable"] it would be more robust.

We should consider going even further and just provide stable_only = true|false parameter.

@lmolkova
Copy link
Contributor Author

Great suggestion from @jerbly in the chat

Second hole plug suggestion: We could change the logic of is_experimental to return true by default: https://github.com/open-telemetry/weaver/blob/main/crates/weaver_forge/src/extensions/otel.rs#L280-L292 (edited)

@lmolkova lmolkova moved this to To consider for the next release in OTel Weaver Project Jan 28, 2025
@jsuereth jsuereth moved this from To consider for the next release to Next Release in OTel Weaver Project Jan 29, 2025
@jsuereth jsuereth assigned lmolkova and unassigned lquerel Feb 5, 2025
@lmolkova lmolkova linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Next Release
Development

Successfully merging a pull request may close this issue.

2 participants