From 5db60f41edd224305a5aaeee9bbf0d66a42b301a Mon Sep 17 00:00:00 2001 From: Severin Neumann Date: Tue, 6 Feb 2024 12:53:20 +0100 Subject: [PATCH 1/3] Add an issue template for maintainer onboarding --- .../ISSUE_TEMPLATE/maintainer-onboarding.yml | 81 +++++++++++++++++++ 1 file changed, 81 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/maintainer-onboarding.yml diff --git a/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml b/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml new file mode 100644 index 000000000..e9fb29429 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml @@ -0,0 +1,81 @@ +name: Maintainer Onboarding +description: Onboarding checklist for maintainers +title: "Onboard as maintainer" +labels: area/github-membership +body: +- type: markdown + attributes: + value: | + This issue should be submitted by an existing maintainer of the affected SIG +- id: sig + type: input + attributes: + label: "SIG name" + placeholder: "SIG example" + validations: + required: true +- id: maintainers_group + type: input + attributes: + label: "maintainers team" + placeholder: "@opentelemetry/-maintainers" + description: Tag the maintainers group. If unsure, you can [look groups up](https://github.com/orgs/open-telemetry/teams?query=maintainers) + validations: + required: true +- id: github_handle + type: input + attributes: + label: "Github handle of the new maintainer candidate" + placeholder: "@example" + validations: + required: true +- id: requirements + type: checkboxes + attributes: + label: Requirements + description: Before submitting + options: + - label: Are you (submitter of this issue) a maintainer of the affected SIG? + required: true + - label: Is the maintainer candidate a member of the OpenTelemetry GitHub organization already? + required: true +- id: election + type: checkboxes + attributes: + label: Maintainer Election + description: | + Unless stated otherwise in a SIG charter ratified by the Technical Committee, all existing maintainers are asked to vote, + if the candidate should be added to their group of maintainers. They vote by commenting "I support" or "I do not support" on this issue. + The election is over, when a majority of the maintainers have voted. If the majority have voted in favour of the candidate, the candidate + can accept (or decline) the vote by commenting "I accept" or "I decline". If the candidate has not been elected, the issue can be closed. + options: + - label: Has the candidate been elected? + - label: Has the candidate accepted? +- id: onboarding + type: checkboxes + attributes: + label: Maintainer Onboarding Tasks + description: | + After the maintainer has been elected, the following check list helps to verify that the maintainer has everything needed + to fullfil their responsibility. + options: + - label: Added to the `@opentelemetry/-maintainers` GitHub group + - label: Added to `#otel-maintainers` slack channel + - label: Added to the `maintainers` section in the SIGs repositories `README.md` + - label: Added to [opentelemetry-calendar-contributors Google Group](https://groups.google.com/g/opentelemetry-calendar-contributors) + - label: Added to any other groups, slack channels or resources that SIG maintainers require + - label: Invited to SIG meetings and Maintainer meeting. +- id: tasks + type: checkboxes + attributes: + label: Prerequisites for new maintainer + description: | + The maintainer is asked to review the following checklist, fullfil the items and check them off. When all items of this list are completed, this issue can be closed + options: + - label: Completed all **Maintainer Onboarding Tasks** (see above) + - label: Reviewed the [Code of Conduct](./code-of-conduct.md) + - label: Reviewed [requirements, responsibilites and privileges](./community-membership.md#maintainer) + - label: Reviewed [mission, vision, values](./mission-vision-values.md) + - label: Reviewed all SIG specific documents that are relevant for a maintainer + - label: Scheduled a introductory call (30-60 minutes) with a GC member + - label: Completed the [Inclusive Open Source Community Orientation course](https://training.linuxfoundation.org/training/inclusive-open-source-community-orientation-lfc102/) From ccd0c8c6de33a0169c5132c69ab8848477e81437 Mon Sep 17 00:00:00 2001 From: Severin Neumann Date: Tue, 6 Feb 2024 15:02:47 +0100 Subject: [PATCH 2/3] Update community-membership.md --- community-membership.md | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/community-membership.md b/community-membership.md index 5ee95fe90..71324241c 100644 --- a/community-membership.md +++ b/community-membership.md @@ -227,18 +227,22 @@ The following apply to the subproject for which one would be a maintainer. ### Becoming a Maintainer Unless stated otherwise in a SIG charter ratified by the Technical Committee, -a new maintainer is elected by vote of the existing maintainers of the SIG. -The vote is officially started when a pull request to add a new maintainer -is opened, and ends when the pull request is merged. The pull request may be -merged when the following conditions are met: - -- The person being nominated has accepted the nomination by approving the pull request -- All maintainers have approved the pull request OR a majority of maintainers - have approved the pull request and no maintainer has objected by requesting - changes on the pull request. In the case that all maintainers have not given - approval, the pull request should stay open for a minimum of 5 days before merging. - -The nominee is considered a maintainer after the pull request is merged. +a new maintainer is elected by vote of thee existing maintainers of the SIG. +The vote is officially started when an +[issue is created](https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fonboarding&template=maintainer-onboarding.yml&title=Maintainer+Onboarding%3A+%3CGH_USERNAME%3E) +to add the nominee as a new maintainer. All existing maintainers of the SIG +are asked to vote by commenting "I support" or "I do not support" on this issue. +The election is over, when a majority of the maintainers have voted: + +- If the majority have voted in favour of the nominee, the candidate accepts +(or declines) the vote by commenting "I accept" or "I decline". The nominee is +considered a maintainer immediatly after they accepted. +- If the majority have voted against the nominee becoming a maintainer, the +issue can be closed and the nominee has not been elected. + +In the case that no majority in favour or against the nominee can be accomplished +within 5 days, a minority vote sufficies. + #### Self-nomination is encouraged From d1d1097773ac6d1637e2d01bd62ac4339f541700 Mon Sep 17 00:00:00 2001 From: Severin Neumann Date: Fri, 9 Feb 2024 10:14:44 +0100 Subject: [PATCH 3/3] Update .github/ISSUE_TEMPLATE/maintainer-onboarding.yml --- .github/ISSUE_TEMPLATE/maintainer-onboarding.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml b/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml index e9fb29429..8b847826f 100644 --- a/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml +++ b/.github/ISSUE_TEMPLATE/maintainer-onboarding.yml @@ -1,7 +1,7 @@ name: Maintainer Onboarding description: Onboarding checklist for maintainers title: "Onboard as maintainer" -labels: area/github-membership +labels: area/onboarding body: - type: markdown attributes: