Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: selecting the number of contributors makes a minor resize #2234

Open
1 of 2 tasks
a0m0rajab opened this issue Nov 29, 2023 · 7 comments
Open
1 of 2 tasks

Bug: selecting the number of contributors makes a minor resize #2234

a0m0rajab opened this issue Nov 29, 2023 · 7 comments
Labels
🐛 bug Something isn't working 🎨 style Visual issues not impacting functionality
Milestone

Comments

@a0m0rajab
Copy link
Contributor

a0m0rajab commented Nov 29, 2023

Describe the bug

If you go to https://beta.app.opensauced.pizza/javascript/dashboard/filter/recent?range=30&limit=20 and change the number of contributors from 10 to 20 or 50 a minor resize happens to the selector
image

Steps to reproduce

  1. go to https://beta.app.opensauced.pizza/javascript/dashboard/filter/recent?range=30&limit=20
  2. change the number of contributors per page and see the minor difference.

Browsers

No response

Additional context (Is this in dev or production?)

Discovered in #2185

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@a0m0rajab a0m0rajab added 🐛 bug Something isn't working 👀 needs triage labels Nov 29, 2023
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added the 🎨 style Visual issues not impacting functionality label Nov 29, 2023
@nickytonline nickytonline added this to the Papercuts milestone Nov 29, 2023
@RitaDee
Copy link
Contributor

RitaDee commented Nov 30, 2023

I will .take this

Copy link
Contributor

The issue you are trying to assign yourself is blocked until it can be triaged or by another label on the issue.

@a0m0rajab
Copy link
Contributor Author

@RitaDee hi rita, I just removed the needs triage label and assigned you to the issue.
Minor thought, having a minimum width for this would help.

@RitaDee
Copy link
Contributor

RitaDee commented Nov 30, 2023

@RitaDee hi rita, I just removed the needs triage label and assigned you to the issue. Minor thought, having a minimum width for this would help.

Thanks, @a0m0rajab.

@RitaDee RitaDee removed their assignment Dec 11, 2023
@aryanas159
Copy link
Contributor

We have fixed this issue in the DropdownMenu component by defining the component non-modal, but sadly there is no such prop for the Select component in Radix yet, there is a pull request made to their library that will add this functionality. According to the fixes I have found, we would have to make a few global CSS changes for this.
@nickytonline I would love to hear your thoughts on this.

@brandonroberts
Copy link
Contributor

I'm not seeing this issue anymore, can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🎨 style Visual issues not impacting functionality
Projects
None yet
Development

No branches or pull requests

5 participants