Bug: Active, new and alumni contributors add up incorrectly on list overview page

[nickytonline]

Describe the bug

Active, new and alumni contributors add up incorrectly on list overview page

Steps to reproduce

1. Navigate to http://localhost:3000/lists/8b371419-6219-4448-9de1-f6293a25f98e/overview

Notice the cards don't add up to 18.

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[github-actions]

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

[nickytonline]

From what I can tell in the list overview page, the active contributors card is loading the total of all contributors, allContributorMeta.itemCount, instead of the active contributor count.

app/pages/lists/[listId]/overview.tsx

Lines 162 to 170 in 02c4946

	<HighlightCard
	label="Active Contributors"
	icon="active-contributors"
	metricIncreases={allContributorMeta.itemCount > prevAllContributorMeta.itemCount}
	increased={allContributorMeta.itemCount > prevAllContributorMeta.itemCount}
	numChanged={allContributorMeta.itemCount - prevAllContributorMeta.itemCount}
	value={allContributorMeta.itemCount}
	isLoading={prevAllContributorStatsLoading || allContributorStatsLoading}
	/>

The data should be coming in from a new data source, e.g.

  const { meta: activeContributorMeta, isLoading: activeContributorStatsLoading } = useListStats(
    listId as string,
    "active"
  );

[OgDev-01]

Do we need this open? cc: @brandonroberts

[brandonroberts]

Yes, we will close this out as part of the API v2 refactor