Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Redirect issues happening when click tabs from a list without range or limit in the URL #2211

Closed
1 of 2 tasks
brandonroberts opened this issue Nov 27, 2023 · 4 comments · Fixed by #2214
Closed
1 of 2 tasks
Assignees
Labels
🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on high-priority Work on these issues first released on @beta released

Comments

@brandonroberts
Copy link
Contributor

Describe the bug

When visiting a list and switching to the contributors tab, the data isn't displayed correct unless the limit query param is set

Screen.Recording.2023-11-27.at.2.04.29.PM.mov

Steps to reproduce

  1. Navigate to a list https://app.opensauced.pizza/lists/759e58cd-2e89-4704-8def-93d911716b82/overview
  2. Click on the activity tab, notice the redirect to include the range query param
  3. Click on the contributors tab, notice the empty data for the contributors
  4. Add the limit=10 query param to the URL
  5. Notice the contributors data shows up correctly.

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@brandonroberts brandonroberts added 🐛 bug Something isn't working high-priority Work on these issues first core team work Work that the OpenSauced core team takes on labels Nov 27, 2023
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@a0m0rajab
Copy link
Contributor

a0m0rajab commented Nov 27, 2023

hi @OgDev-01 if you are working on this I think setting the limit option at this lines would solve the issue:

useEffect(() => {
if (!range) {
setQueryParams({ range: "30" });
}
}, [range]);

In that page the limit is being used twice by the way.

Copy link
Contributor

open-sauced bot commented Nov 29, 2023

🎉 This issue has been resolved in version 1.78.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Nov 29, 2023

🎉 This issue has been resolved in version 1.78.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on high-priority Work on these issues first released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants