Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Checkboxes on the User Settings Page Need Focus States #2149

Closed
2 tasks done
nickytonline opened this issue Nov 15, 2023 · 6 comments · Fixed by #2206
Closed
2 tasks done

Bug: Checkboxes on the User Settings Page Need Focus States #2149

nickytonline opened this issue Nov 15, 2023 · 6 comments · Fixed by #2206
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on released on @beta released

Comments

@nickytonline
Copy link
Member

Describe the bug

Checkboxes on the User Settings Page Need Focus States

Steps to reproduce

  1. Go to your user settings page, https://app.opensauced.pizza/user/settings
  2. Use the TAB key to tab through all the fields. Notice that once you hit a checkbox, you can change it's state with the keyboard, but it never receives a focus state.

CleanShot 2023-11-14 at 22 41 55

Browsers

No response

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@nickytonline nickytonline added 🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on a11y Issues related to accessibility labels Nov 15, 2023
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member Author

We should add default focus states to the base styles for this @isabensusan @OgDev-01 so that the focus states become uniform throughout the site. We can then also probably remove a lot of focus state styles throughout all the components that have them.

@nickytonline nickytonline changed the title Bug: Checkboxes on the USer Settings Page Need Focus States Bug: Checkboxes on the User Settings Page Need Focus States Nov 15, 2023
@nickytonline
Copy link
Member Author

@isabensusan
Copy link
Member

@nickytonline Yes!! I'd love to have global focus styles. I think the styling we have for the search component is ideal:

image

Here's the tailwind classes making this happen:


focus-within:ring 
focus-within:border-orange-500 
focus-within:ring-orange-100

Copy link
Contributor

open-sauced bot commented Nov 28, 2023

🎉 This issue has been resolved in version 1.78.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link
Contributor

open-sauced bot commented Nov 29, 2023

🎉 This issue has been resolved in version 1.78.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working core team work Work that the OpenSauced core team takes on released on @beta released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants