Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove tailwind anti-pattern in /start.tsx route #2128

Open
2 tasks done
5hraddha opened this issue Nov 13, 2023 · 2 comments
Open
2 tasks done

Refactor: Remove tailwind anti-pattern in /start.tsx route #2128

5hraddha opened this issue Nov 13, 2023 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@5hraddha
Copy link
Contributor

Describe the bug

The /start.tsx route is having the hardcoded pixels/percentage values - a tailwind anti-pattern. It will be great to refactor it with suitable Tailwind classes instead. To find the anti-pattern we can use this regex ^.*?-\[[^\d]*(\d+)[^\d]*\].*$

This issue is related with #1522 and #2053.

Proposed Solution

Refactor the code with suitable Tailwind classes.

Steps to reproduce

  1. Go to /start.tsx route.
  2. Perform a find using regex ^.*?-\[[^\d]*(\d+)[^\d]*\].*$.

Browsers

Chrome

Additional context (Is this in dev or production?)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@5hraddha 5hraddha added 🐛 bug Something isn't working 👀 needs triage labels Nov 13, 2023
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@ThePiyushAggarwal
Copy link
Contributor

.take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants