Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link user avatar on feeds page to their profile #1986

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

OgDev-01
Copy link
Contributor

Description

This PR links the users avatar in feeds page to their profile page

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

fixes #1981

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2023-10-23.at.16.47.39.mov

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 23, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 1e224b1
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/65369601cd83a600089fd3ad
😎 Deploy Preview https://deploy-preview-1986--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 23, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit 1e224b1
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/65369601ee73e700071ed8ad
😎 Deploy Preview https://deploy-preview-1986--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 changed the title fix: link user avatar to profile page fix: link user avatar on feeds page to their profile Oct 23, 2023
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonroberts brandonroberts merged commit 24ca123 into beta Oct 23, 2023
@brandonroberts brandonroberts deleted the 1981-ink-avatar-to-profile branch October 23, 2023 15:57
open-sauced bot pushed a commit that referenced this pull request Oct 23, 2023
## [1.72.0-beta.4](v1.72.0-beta.3...v1.72.0-beta.4) (2023-10-23)

### πŸ› Bug Fixes

* link user avatar on feeds page to their profile ([#1986](#1986)) ([24ca123](24ca123))
* popover display issue of safari ([#1962](#1962)) ([afe5ab2](afe5ab2))
open-sauced bot pushed a commit that referenced this pull request Oct 24, 2023
## [1.72.0](v1.71.1...v1.72.0) (2023-10-24)

### πŸ• Features

* add hovercards to list contributors page ([01ca13c](01ca13c))
* add hovercards to list contributors page ([#1980](#1980)) ([7e5ab98](7e5ab98))

### πŸ§‘β€πŸ’» Code Refactoring

* remove key ([b84d4b1](b84d4b1))
* Rename the [filterName] query to more accurate naming in `/pages` routes ([#1753](#1753)) ([87bd6a3](87bd6a3))
* show tootip indication for disabled CTA when repo limit is reached ([#1915](#1915)) ([4b675a0](4b675a0))

### πŸ› Bug Fixes

* add build command to Netlify `.toml` configuration ([#1961](#1961)) ([973be2f](973be2f))
* add placeholder for 0 pending connection request ([#1989](#1989)) ([70d6046](70d6046))
* add responsiveness to profile detail ([294abd0](294abd0))
* added missing is_maintainer info for Posthog ([b9c0c1e](b9c0c1e))
* added missing is_maintainer info for Posthog ([#1975](#1975)) ([25d603b](25d603b))
* link user avatar on feeds page to their profile ([#1986](#1986)) ([24ca123](24ca123))
* No more 404 errors in the browser console ([#1983](#1983)) ([c6c73f7](c6c73f7))
* notification indicator ([#1955](#1955)) ([fd78097](fd78097))
* popover display issue of safari ([#1962](#1962)) ([afe5ab2](afe5ab2))
* remove orange notification indicator on button click ([574f575](574f575))
* removed chatbot ([#1973](#1973)) ([4c58e42](4c58e42))
* renamed needs triage label as it was breaking our issue creation workflow ([#1968](#1968)) ([0b0ac4b](0b0ac4b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make user avatar on feed link to user profile
3 participants