Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add targeting validation and log warning if targeting is invalid #1140

Closed
2 tasks
toddbaert opened this issue Jan 8, 2024 · 2 comments · Fixed by #1146
Closed
2 tasks

[FEATURE] Add targeting validation and log warning if targeting is invalid #1140

toddbaert opened this issue Jan 8, 2024 · 2 comments · Fixed by #1146
Assignees
@olunusib
Labels
enhancement New feature or request

Comments

@toddbaert
Copy link
Member

Requirements

With open-feature/flagd-schemas#120, we now have JSON schema validation for targeting rules. We can now validate targeting rules for all sources. We should do this, and log a WARNING anytime an flag with invalid targeting is configured.

Tasks:

  • update schemas submodule to most recent release
  • add targeting and root schema (see example here) and validate it, logging a warning if it's not valid
@toddbaert toddbaert added the enhancement New feature or request label Jan 8, 2024
@olunusib olunusib mentioned this issue Jan 15, 2024
Merged
@toddbaert toddbaert mentioned this issue Jan 15, 2024
Merged
@toddbaert
Copy link
Member Author

@olunusib would you like me to assign this to you?

@olunusib
Copy link
Contributor

Yes please, thanks!

toddbaert added a commit that referenced this issue Jan 16, 2024
@olunusib @toddbaert
feat: add targeting validation (#1146)
b727dd0 
- adds targeting validation
- updates sample json files
- updates schemas modules to most recent release

Closes #1140 

Signed-off-by: Best Olunusi <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olunusib olunusib

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add targeting validation olunusib/flagd
2 participants
@toddbaert @olunusib