Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flagd] migrate e2e tests to use test containers for container image starts #307

Open
aepfli opened this issue Dec 17, 2024 · 0 comments
Open

Comments

@aepfli
Copy link
Member

aepfli commented Dec 17, 2024

Within the Java, Python, and JS SDK, we have already moved to testcontainers.org for testing with the test-harness. It reduces the pain and effort, as the containers are started as part of the tests, rather than an extra ci step and/or locally an additional docker command.

Within our ci files:

services:
# flagd-testbed for flagd RPC provider e2e tests
flagd:
image: ghcr.io/open-feature/flagd-testbed:v0.5.6
ports:
- 8013:8013
# sync-testbed for flagd in-process provider e2e tests
sync:
image: ghcr.io/open-feature/sync-testbed:v0.5.6
ports:
- 9090:9090

for running the tests locally:
https://github.com/open-feature/dotnet-sdk-contrib/blob/main/src/OpenFeature.Contrib.Providers.Flagd/docker-compose.yaml

See: https://dotnet.testcontainers.org/ how to integrate testcontainers

This issue blocks #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant