Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4] Update Firebase dependency to support EU and AP regions #192

Open
willroberts opened this issue Oct 23, 2022 · 2 comments
Open

[P4] Update Firebase dependency to support EU and AP regions #192

willroberts opened this issue Oct 23, 2022 · 2 comments
Labels
enhancement New feature or request frontend Related to app / game client code help wanted Extra attention is needed

Comments

@willroberts
Copy link
Collaborator

Summary

Creating a Firebase Realtime Database in EU (Belgium) or AP (Singapore) results in a Firebase URL which does not end in firebaseio.com, which is required by our current Firebase dependency.

We should upgrade the firebase package to a version which supports these endpoints.

@willroberts willroberts added enhancement New feature or request help wanted Extra attention is needed frontend Related to app / game client code labels Oct 23, 2022
@willroberts
Copy link
Collaborator Author

This may be the version we need: https://firebase.google.com/support/release-notes/js#version_7145_-_may_21_2020

We should probably avoid version 8.x (which switches to ES6 modules) and 9.x (which changes the package structure to a modular format, requiring code changes) for now.

@willroberts
Copy link
Collaborator Author

Upgrading directly to 7.14.5 with no other changes produces an error:

Unhandled rejection [1]</App.getMinBrowserVersions/<@http://localhost:3000/duelyst.js:3491:28

And a warning:

It looks like you're using the development build of the Firebase JS SDK.
When deploying Firebase apps to production, it is advisable to only import
the individual SDK components you intend to use.

It seems version 7.x also requires code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to app / game client code help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant