Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Diff Tuning via Command Args? #43

Open
rpringst opened this issue Sep 29, 2022 · 7 comments
Open

Share Diff Tuning via Command Args? #43

rpringst opened this issue Sep 29, 2022 · 7 comments

Comments

@rpringst
Copy link

Is it possible to introduce a command line argument which sets the share static difficulty? Currently it is 4. I identified where it is within the code base, but am unsure if just changing that one value and rebuilding will work... Thanks in advance.

@RulezZzOr
Copy link

could be interesting, do you think that time for finding will be less?

@rpringst
Copy link
Author

@RulezZzOr - I think that sending too many shares per minute 'wastes' time. Theoretically, share difficulty shouldn't matter as we sample out to infinity, but because of how quickly blocks move on Kaspa, submitting a share, waiting for stratum server response, and also beginning work on a new job (plus the possibility that mid-submit, a new job may be available), all add up to what I feel is a non-trivial proportion of blocktime.

@onemorebsmith
Copy link
Owner

Share tuning can be added in the future, but I'm not sure the real benefit here. Diff 4 (~17G diff) is pretty standard for pools.

@rpringst new block notifications preempt the miner so that shouldn't be an issue. Kaspa also allows miners to mine pass blocks within a timeframe (~10 blocks) to compensate for the fast block times

@rpringst
Copy link
Author

You have good points. FWIW, None of the major pools use 4 anymore it seems, most start at 10 and some vardiff down to 5.

@rdugan
Copy link
Contributor

rdugan commented Oct 19, 2022

A configurable diff is good for cutting down network traffic and log spam if nothing else. I've actually just implemented it on my fork while also reorganizing things a bit which should allow for an easier vardiff implementation in the future. Also added a config for the block refresh timeout while i was at it.

Will submit a pull request after testing for a bit longer.

@rpringst
Copy link
Author

@rdugan I'll give your fork a build today and test it too!

@rdugan
Copy link
Contributor

rdugan commented Oct 26, 2022

Haven't had any issues over the past week. Couple other people w/ some significant firepower have been using the new features for a few days as well without issue. Submitted the pull request...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants