Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] (nit) deprecate "Web Search" extension #1305

Open
milnak opened this issue Jan 6, 2025 · 1 comment
Open

[Feature Request] (nit) deprecate "Web Search" extension #1305

milnak opened this issue Jan 6, 2025 · 1 comment

Comments

@milnak
Copy link

milnak commented Jan 6, 2025

Consider shipping "Custom Web Search" with some defaults and "Web Search" won't be needed anymore.

Suggested defaults:

    "extension[CustomWebSearch].customSearchEngines": [
        {
            "id": "6b0bd2d7-819a-4e95-812c-b68ff7d0b0b0",
            "name": "Wikipedia",
            "prefix": "wikipedia",
            "url": "https://en.wikipedia.org/w/index.php?search={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "12edd5f7-2f96-4940-8910-399cc59508c1",
            "name": "AllMusic",
            "prefix": "allmusic",
            "url": "https://www.allmusic.com/search/all/{{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "6878bfcf-25bd-4e6c-b80b-3f52a963c889",
            "name": "GitHub",
            "prefix": "github",
            "url": "https://github.com/search?q={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "fa02d011-9ca7-413f-be03-a562b7a81235",
            "name": "YouTube",
            "prefix": "youtube",
            "url": "https://www.youtube.com/results?search_query={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "78118a22-feb3-4df4-b93d-ea4908e6cd2f",
            "name": "Google",
            "prefix": "google",
            "url": "https://www.google.com/search?q={{query}}&udm=14",
            "encodeSearchTerm": true
        },
        {
            "id": "036e92b6-c518-4c8e-9fc8-8eeeb52d89a8",
            "name": "DuckDuckGo",
            "prefix": "duckduckgo",
            "url": "https://duckduckgo.com/q={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "ccdb29a3-6a4a-4164-92ef-1c56ae8eb85b",
            "name": "Genius",
            "prefix": "genius",
            "url": "https://genius.com/search?q={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "92a9dbf5-f05a-4cb7-ac4d-2a5f94f8c4ab",
            "name": "IMDB",
            "prefix": "imdb",
            "url": "https://www.imdb.com/find/?q={{query}}",
            "encodeSearchTerm": true
        },
        {
            "id": "9bbea4d8-5624-4c3c-8d25-7eb3d80e7957",
            "name": "YouTube",
            "prefix": "youtube",
            "url": "https://www.youtube.com/results?search_query={{query}}",
            "encodeSearchTerm": true
        }
    ],
@oliverschwendener
Copy link
Owner

Thanks for the idea, I agree that it would make sense to merge those extensions. There is one feature though that the Custom Web Search extension is missing currently: searching for suggestions offered by the search engine. This needs to be implemented first before it's feature-par. See this example screenshot from the Web Search extension:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants