From 61ebe7d8880d668a3067b08e4ac4843850d5f563 Mon Sep 17 00:00:00 2001 From: Mike Mondragon Date: Fri, 9 Feb 2024 09:35:23 -0800 Subject: [PATCH] Fix Open browser and open browser command behavior that was fouled in v2 release. Closes #168 --- CHANGELOG.md | 8 ++++++++ internal/config/config.go | 4 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 823563d..e96aa95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # Changelog +## Major.Minor.Revision (Month Day, Year) + +TBD + +### BUG FIXES + +* Open browser and open browser command behavior was fouled in v2 release [#NNN](https://github.com/okta/okta-aws-cli/pull/NNN), thanks [@monde](https://github.com/monde)! + ## 2.0.1 (January 31, 2024) ### ENHANCEMENTS diff --git a/internal/config/config.go b/internal/config/config.go index ebcf836..9c10fa2 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -453,9 +453,11 @@ func readConfig() (Attributes, error) { attrs.OpenBrowser = viper.GetBool(downCase(OpenBrowserEnvVar)) } if attrs.OpenBrowserCommand == "" { + attrs.OpenBrowserCommand = viper.GetString(downCase(OpenBrowserCommandEnvVar)) + } + if attrs.OpenBrowserCommand != "" { // open browser command implies open browser attrs.OpenBrowser = true - attrs.OpenBrowserCommand = viper.GetString(downCase(OpenBrowserCommandEnvVar)) } if !attrs.Debug { attrs.Debug = viper.GetBool(downCase(DebugEnvVar))