Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow revoking 'Anyone' invite link when creator/admin is no longer a group member #2416

Open
dotmacro opened this issue Nov 10, 2024 · 3 comments
Assignees

Comments

@dotmacro
Copy link
Member

Problem

Currently, only the group admin/creator can revoke the "Anyone" invite link. When the admin/creator leaves the group, no other members can revoke the link. This is a great security/privacy concern because if the link is accidentally posted publicly or sent to the wrong email/account/etc, people not meant to be part of the group can join and no other members can prevent this from happening.

Solution

The "Anyone" invite link must be revocable by other group members when the admin/creator is no longer a member of the group.

@dotmacro
Copy link
Member Author

Who else should be able to revoke the "Anyone" invite link?

@SebinSong SebinSong self-assigned this Dec 26, 2024
@SebinSong
Copy link
Collaborator

SebinSong commented Dec 28, 2024

When the admin/creator leaves the group, no other members can revoke the link.

When a group creator leaves a group, a feature like below becomes unavailable for the group too apparently.

And the permission to these features is governed by this groupOwnerID of the group's state.

@taoeffect
Q. What's your thoughts on the idea that the second earliest member of the group automatically becomes the group owner, when the group owner leaves the group? (And then probably also emitting a group notification that let people know this)

@taoeffect
Copy link
Member

@SebinSong @dotmacro This issue is really an extension of existing issue #202 — Permissions system via Roles & Permissions.

That issue is what needs to be closed in order to close this issue.

The general idea is that various actions in the app can require that the user performing those actions must have certain permissions. A "role" is a name given to a group of permissions (e.g. "admin" and "moderator" would be roles with different permissions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants