Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service info access method assumes off-spec route #39

Open
uniqueg opened this issue Jan 27, 2023 · 2 comments · Fixed by #46
Open

Service info access method assumes off-spec route #39

uniqueg opened this issue Jan 27, 2023 · 2 comments · Fixed by #46
Assignees
Milestone

Comments

@uniqueg
Copy link
Collaborator

uniqueg commented Jan 27, 2023

In py-tes 0.4.2 (and probably earlier) the service info controller assumes a route that is incompatible with the TES v1.0 and v1.1 specifications.

In particular, the controller assumes a route v1/tasks/service-info, while the specs require v1/service-info (or rather ga4gh/tes/v1/service-info, compare #40), without tasks/.

@uniqueg
Copy link
Collaborator Author

uniqueg commented Feb 9, 2023

Here the possible options I see are pretty much number 2. and 3. from #40:

  • Expect the endpoint at /service-info (could still work for current Funnel if the py-tes consumer tries passing f"{url}/tasks/ - just for accessing the service info)
  • Try both locations, starting with /service-info, then, in case of 404, trying /service-info/tasks for legacy support

There isn't really an equivalent to 1. obviously.

What do you think, @kellrott?

@kellrott kellrott added this to the 0.5.0 milestone Feb 10, 2023
@uniqueg uniqueg self-assigned this Feb 10, 2023
@uniqueg uniqueg changed the title Service info controller assumes off-spec route Service info access method assumes off-spec route Feb 10, 2023
@uniqueg
Copy link
Collaborator Author

uniqueg commented Feb 10, 2023

Following #40, will go for the second option here.

Changing the endpoint is an issue for Funnel v1.1 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants