Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I add other language for constellations names? #91

Open
evheniydan opened this issue Aug 1, 2020 · 3 comments
Open

How can I add other language for constellations names? #91

evheniydan opened this issue Aug 1, 2020 · 3 comments

Comments

@evheniydan
Copy link

Hi! In constellations.json I've tried to add new properties (for example, "ua":"name1", "ua":"name2" etc.) to some constellations and then applying config.lang = "ua". But that doesn't seem to work. Any help would be much appreciated

@ofrohn
Copy link
Owner

ofrohn commented Aug 3, 2020

For security purposes the language setting is checked in config.js against a list of all available languages and only applied when it appears in it.
So if you add the line "ua": "Ukrainian" to the object 'formats' under "constellations" -> "iau" -> "names", it should work.
And if you are successful, please add the changes as a pull request, it would be a very welcome addition.

@evheniydan
Copy link
Author

Unfortunately, this doesn't seem to work. The optput is still the same. Any more ideas?

@ofrohn
Copy link
Owner

ofrohn commented Aug 11, 2020

I tried adding Kiswahili to the constellation names and when I set lang: 'sw' it works as intended, set all object names for which the selected language is available to it (in this case only constellations).
If it doesn't work for you, I'd need to see some code to check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants