Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GCSFuse 0.34.1 #68

Closed
fradeve opened this issue Apr 7, 2021 · 7 comments · Fixed by #70
Closed

Support for GCSFuse 0.34.1 #68

fradeve opened this issue Apr 7, 2021 · 7 comments · Fixed by #70

Comments

@fradeve
Copy link

fradeve commented Apr 7, 2021

Hi,
before everything else, thanks again for your work on this project!

Is there any plan for releasing an updated version csi-gcs that uses v0.34.1 of GCSFuse? The GoogleCloudPlatform made some good progress on some outstanding issues with the upload of large files, and it would be great to take advantage of them in this project as well!

I am mostly referring to:

Thanks again!

@maennchen
Copy link
Collaborator

@fradeve I would gladly accept a PR for this. 👍

@fradeve
Copy link
Author

fradeve commented Apr 8, 2021

Hi @maennchen, thanks for getting back to me on this :) Sadly we don't have the Go expertise (yet) to help with the work, but if there is anything we could help with (e.g. docs or project management) I will gladly look into it!

@maennchen
Copy link
Collaborator

I've planned to do some work on this sometime in the future. (Update everything & implement #61 & #47)

I don't have time currently and it will take some time until I get to this.

This was the first project that I ever contributed to in go. I really recommend just trying if you can do it :)

@ofek
Copy link
Owner

ofek commented Apr 9, 2021

@fradeve see: #63

@ofek
Copy link
Owner

ofek commented Apr 18, 2021

#70

@ofek ofek closed this as completed in #70 Apr 18, 2021
@fradeve
Copy link
Author

fradeve commented Apr 19, 2021

@ofek I owe you an apology... if I knew this was that easy, I would have done it myself and opened a PR!

@ofek
Copy link
Owner

ofek commented Apr 19, 2021

Ah no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants