generator.dependencies as a list feels awkward in some cases

[ldesgoui]

When generator.script uses deps in a homogeneous fashion, like in the example, it feels fine, but when I try to generate an environment file where each dep goes to a specific value, it becomes a bit of a burden, handling lists with nix isn't the nicest. I suppose lib.zipListsWith exists.

It feels like it should be possible to type generator.dependencies with oneOf [listOf secret, attrsOf secret], deps would become a list or attrset depending on the input. Heck, we could even have a pre-written env-from-dependencies script for the simple case.

Is this design acceptable? I can try my hand at implementing it, doesn't seem like too much work, but I haven't looked too deep yet.

[oddlama]

You're right, using a list wasn't the best idea. I don't know if it is worthwhile to change this now without breaking anything that already exists. For the medium term I'm rooting for a design like NixOS/nixpkgs#370444 which would provide a way to define generators upstream in nixos and deprecate our age-specific interface.

If you still want to have a go at it, feel free! If you end up with something that is compatible with current configurations we can definitely merge it.

[ldesgoui]

I don't know if it is worthwhile to change this now without breaking anything that already exists.

I don't believe that changing the type from listOf unspecified to oneOf [listOf unspecified, attrsOf unspecified] would break any existing code, I could write tests to make sure of it

[oddlama]

What I meant is that currently all existing generators expect a list. If you only want to change the option and not the deps argument in the generators, then I guess there will be no way this can break. In any case, have a look at this snippet:

agenix-rekey/apps/generate.nix

Lines 76 to 80 in a1dcdd2

	deps = flip map secret.generator.dependencies (dep: {
	host = findHost dep;
	name = dep.id;
	file = relativeToFlake dep.rekeyFile;
	});

Here, the deps argument is constructed. If you want the benefits of an attrset in your generator scripts, then you'd have to change this representation, and that may break generators that depend on it being a list. That's what I was referring to.

[ldesgoui]

That's technically true but thinking about the bigger picture, a script that expects deps to be a list will always have dependencies be a list so I wouldn't expect any actual breakage

[oddlama]

Closed by #71