Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a better solution for how we handle claim_pattern #90

Open
mattmoor opened this issue Feb 5, 2024 · 0 comments
Open

Come up with a better solution for how we handle claim_pattern #90

mattmoor opened this issue Feb 5, 2024 · 0 comments

Comments

@mattmoor
Copy link
Member

mattmoor commented Feb 5, 2024

Right now we have to explicitly enumerate these in our schema because BigQuery doesn't support map[string]string. This leads to tedious changes like #89 when a users adds a new claim they want to match on (a losing battle).

Instead we should consider solutions such as serializing this field to a list of (name, value) pairs as we do for the actor claims.

@mattmoor mattmoor added bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists and removed bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant