Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miou < 0.2.0 didn't support OCaml 5.3 #27200

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

kit-ty-kate
Copy link
Member

expects effect to be a valid identifier

#=== ERROR while compiling miou.0.1.0 =========================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/miou.0.1.0
# command              ~/.opam/5.3/bin/dune build -p miou -j 1
# exit-code            1
# env-file             ~/.opam/log/miou-13-7b98fd.env
# output-file          ~/.opam/log/miou-13-7b98fd.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamldep.opt -modules -impl lib/miou.ml) > _build/default/lib/.miou.objs/miou.impl.d
# File "lib/miou.ml", line 506, characters 15-17:
# 506 |       | effect -> k (Operation.perform effect)
#                      ^^
# Error: Syntax error
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamldep.opt -modules -impl lib/state.ml) > _build/default/lib/.miou.objs/miou__State.impl.d
# File "lib/state.ml", line 27, characters 7-13:
# 27 |    fun effect -> Some (effc effect)
#             ^^^^^^
# Error: Syntax error

@mseri
Copy link
Member

mseri commented Jan 3, 2025

Thanks

@mseri mseri merged commit 33107cc into ocaml:master Jan 3, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants