-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3744): Human-Readable Message for Prohibited Comment #3802
base: master
Are you sure you want to change the base?
feat(#3744): Human-Readable Message for Prohibited Comment #3802
Conversation
@maxonfjvipon Could you have a look, please? |
@volodya-lombrozo it's a very interesting idea, but I'm not sure if it's "right" to put wrong scenarios to grammar to detect errors. It seems that grammar is supposed to contain only "possible" scenarios. Did you see anywhere else such approach when obviously incorrect scenarios are put into grammar to detect syntax errors? |
@maxonfjvipon I share your concern. Actually, using this approach was a last resort. I didn’t want to use it initially.
|
@volodya-lombrozo maybe we should use a two-phases compilation pipeline for the |
In this PR I've added supportive grammar rule that is used to catch prohibited comments and report them to a user:
prohibitedComment : comment ;
Closes: #3744.