Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-authorization vs. re-authentication #116

Open
deansaxe opened this issue Nov 12, 2024 · 8 comments
Open

re-authorization vs. re-authentication #116

deansaxe opened this issue Nov 12, 2024 · 8 comments

Comments

@deansaxe
Copy link

deansaxe commented Nov 12, 2024

Sections 3.2 and 3.3 both use the language “re-authorization of the user is required” when the AS responds with an error to presentation of a refresh token (3.2) or the RS requires step up per RFC9470 (3.3). In both of these cases, re-authorization is required, however, I believe that the requirement is actually re-authentication of the user in order to re-authorize them.

I suggest changing both instances to re-authentication. (Edited to change re-authorization to re-authentication in this sentence.)

@PieterKas
Copy link
Collaborator

Can you clarify if you mean it should be re-authentication or re-authorization? The text suggest you prefer re-authentication, but your recommendation is for re-authorization.

@deansaxe
Copy link
Author

I think that what's necessary is re-authorization, but in order to re-authorize the user, they must be re-authenticated. So my preference is to change the text to re-authentication.

@PieterKas
Copy link
Collaborator

Ok, that is different from your proposal in the issue

I suggest changing both instances to re-authorization.

@embesozzi
Copy link

+1 re-authorization since we are in the context of OAuth. I usually try to say OIDC → authentication and OAuth → authorization (which is really an access delegation standard)

@aaronpk
Copy link
Member

aaronpk commented Nov 12, 2024

Yes I agree these should be "re-authentication". The goal is to leverage the existing step-up spec RFC9470, which has this language:

https://www.rfc-editor.org/rfc/rfc9470#section-3

The authentication event associated with the access token presented with the request does not meet the authentication requirements of the protected resource.

Yes we are talking about user authentication here. I am not actually sure how those two sentences in 3.2 and 3.3 turned in to "re-authorization". The user is not being authorized, the application is, and these sections are talking about the user. So "re-authentication" is correct.

@deansaxe
Copy link
Author

Ok, that is different from your proposal in the issue

I suggest changing both instances to re-authorization.

Yes, I had an error in the original issue. I updated the text in the issue to align with what I intended. Good catch!

@PieterKas
Copy link
Collaborator

Thanks for the clarification Dean. I agree it should read re-authentication.

@deansaxe
Copy link
Author

I filed a PR #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants