verify args should match requests library documentation

[muscovite]

Docstrings for verify args throughout the taxii2client library (example) state that only a bool may be provided. However, this value is ultimately passed to the requests library, which accepts either a bool or string (source).

[chisholm]

Looks to me like verify is passed into _HTTPConnection, which sets it on a requests session:

cti-taxii-client/taxii2client/common.py

Lines 261 to 262 in 54dabad

	self.session = requests.Session()
	self.session.verify = verify

The docs for that attribute are here. They don't document a string as being a supported value type.

[muscovite]

Thanks for double checking!

session.request does support a string for its verify arg: https://github.com/psf/requests/blob/main/src/requests/sessions.py#L550

It looks like session.verify, set by _HTTPConnection as you point out, ends up getting used as the verify value if one wasn't passed to the session.request call:

https://github.com/psf/requests/blob/main/src/requests/sessions.py#L776

https://github.com/psf/requests/blob/main/src/requests/sessions.py#L70

(sorry, not sure how to embed code previews)

Maybe the requests documentation is out of date? I'll look into this a bit further and see an issue should be opened on their end.