Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fun Fact inconsistencies #34

Closed
katevda opened this issue Jul 28, 2020 · 4 comments
Closed

Fun Fact inconsistencies #34

katevda opened this issue Jul 28, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@katevda
Copy link

katevda commented Jul 28, 2020

Wist je dat het gebouw Manufacture Royale de pianos François Berden et Cie - Confiserie Chocolaterie Antoine de volgende typologieën heeft: burgerwoning, werkplaats (ambachtelijk), tentoonstellingszaal, fabriek en herenhuis.
& Wist je dat het gebouw Scholencentrum Sacré-Coeur de Lindthout de volgende typologieën heeft: orgel, school, conservatorium/kunstacademie, kasteel en kerk/kathedraal/basiliek.
& Wist je dat het gebouw Maria Assumptalyceum en Basisschool, Ecole Primaire en Lycée Maria Assumpta en Institut Christ-Roi de volgende typologieën heeft: kinderbewaarplaats, school, pastorie, parochiezaal en kerk/kathedraal/basiliek.
& Wist je dat het gebouw Josaphatpark de volgende typologieën heeft: kiosk, sportcomplex, fontein, Zitbank, brug en beeldhouwwerk en herdenkingsmonument.
& Wist je dat het gebouw Voormalige hoofdzetel van S.A. Les Tramways bruxellois de volgende typologieën heeft: burgerwoning, kantoorgebouw, bijgebouwen, gelijkvloers met handelszaak en herenhuis.
& Wist je dat het gebouw Brusilia de volgende typologieën heeft: pompstation, sportcomplex, appartementsgebouw, winkel en warenhuis/supermarkt.
=> the typologies in these fun facts are grey boxes that lead to the building list but don't actually add to the search
-- @jbelien : Moved (back) to Front-End : oSoc20/urban-brussels#65


Wist u dat er een gebouw is met 46 verschillende bijdragers ? Dit gebouw is Gemeentehuis van Sint-Gillis.
=> The building name here links to the iris monument page instead of our own detail page for it. (This is also the only building name that links to anything, so either link every building name or none?)


undefined
=> Even when I wait this still stays, but might have something to do with clicking on a fun fact tag, going to the building list and then just going back in my browser instead of clicking home (because the home button is not published yet)
-- @jbelien : Moved (back) to Front-End : oSoc20/urban-brussels#62


Less of an issue:
Wist u dat het gebouw Abdij van Dieleghem - voormalige prelaatwoning dateert van 1775, waardoor het één van de oudste gebouwen in Brussel is.
=> building name can link to detail page (has no links now) + maybe also create a tag for years? Or is search on year not enabled right now?

-----> Building name can't link to detail page since there is no specific page for each building
-----> Search by year put on TODO list

Inconsistencies between 'Wist u' and 'Wist je' for the Dutch fun facts (can be 'wist je dat' overall imo)

@jbelien jbelien transferred this issue from oSoc20/urban-brussels Jul 28, 2020
@jbelien
Copy link
Contributor

jbelien commented Jul 28, 2020

Saviez-vous qu'il y existe 143 typologies différentes ?

There is a "y" too much.
"Saviez-vous qu'il existe 143 typologies différentes ?"

@jbelien jbelien added the bug Something isn't working label Jul 28, 2020
@Speedbuilder
Copy link
Contributor

Speedbuilder commented Jul 28, 2020

Saviez-vous qu'il y existe 143 typologies différentes ?

There is a "y" too much.
"Saviez-vous qu'il existe 143 typologies différentes ?"

RESOLVED

@Speedbuilder Speedbuilder self-assigned this Jul 28, 2020
@hrngok
Copy link

hrngok commented Jul 29, 2020

------> RESOLVED (certain buildings had the same intervenant twice and this was not accounted for)

For some intervenants the auto calculation of the buildings does not match with the building numbers on the page. Here an example:
resim

When we click on 'Willy VAN DER MEEREN' tag or seach for him we see that he has 117 buildings instead of 118. In the last page of the buildings he has only 2 buildings.
resim

In my opinion, it might happen due to duplications in "INTERVENANTS" column or it is a parsing issue. Probably some intervenants' names include extra white space at the beginning of the names. When I check results with Python Pandas it shows the number of intervenants as 117
resim

------> RESOLVED (certain buildings had the same intervenant twice and this was not accounted for)

@Speedbuilder
Copy link
Contributor

Closed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants