Remove no longer used session status EXPIRED #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
force-pushed
the
remove_session_expired_status
branch
from
d65190f to
d3e36b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5829 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 462 463 +1
Lines 25186 25189 +3
=========================================
+ Hits 25186 25189 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as the engine is concerned, a run can EXPIRE and that can COMPLETE a session. But we used to shortcut the engine and expire sessions directly so we'd set status = EXPIRED for those sessions.
We do INTERRUPT waiting sessions after 89 days and maybe it would be nicer to call that expiring them but at that point it doesn't really matter because the session object is about to be deleted. Maybe one day that will just be a TTL on a DynamoDB table?