Auto org selection with cross-org object switcher #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5823 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 459 460 +1
Lines 25127 25178 +51
=========================================
+ Hits 25127 25178 +51 ☔ View full report in Codecov by Sentry. |
ericnewcomer
changed the title
| if user.is_staff: | ||
| return org | ||
|
|
||
| membership = org.get_membership(user) |
There was a problem hiding this comment.
seems like this could be combined with line 77
There was a problem hiding this comment.
it feels pretty clear as written to me, what are you proposing exactly?
There was a problem hiding this comment.
I was thinking line 77 could both filter by org id and user membership but it's fine keeping those separate
rowanseymour
approved these changes
Jan 24, 2025
| orgs = user.orgs.filter(is_active=True).order_by("-created_on") | ||
| if orgs.count() > 0: | ||
| # take the newest one | ||
| choose_org = orgs[0] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to add Switch view for normal users when clicking on link for objects they have access to but aren't currently logged in to see. This is a draft, still needs more tests.