End of lines characters are altered by fixes #176
Comments
|
Capturing issues as I find them on my debugging spree, will look for fixes when I'm done on the main item 😄 |
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
4 tasks
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. Fix callback handling in tests, adding missing await and reject handling. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. This only handles Unix '\n' and Windows '\r\n' line endings, not pre MacOSX Mac '\r' as CodeNar doesn't appear to support that line ending. Fix callback handling in tests, adding missing await and reject handling. Validate each file result in folder lint test instead of total. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 17, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. This only handles Unix '\n' and Windows '\r\n' line endings, not pre MacOSX Mac '\r' as CodeNar doesn't appear to support that line ending. Fix callback handling in tests, adding missing await and reject handling. Validate each file result in folder lint test instead of total. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
|
+1! I also support this idea! |
stevenh
added a commit
to stevenh/vscode-groovy-lint
that referenced
this issue
Dec 18, 2023
Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. This only handles Unix '\n' and Windows '\r\n' line endings, not pre MacOSX Mac '\r' as CodeNar doesn't appear to support that line ending. Fix callback handling in tests, adding missing await and reject handling. Validate each file result in folder lint test instead of total. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes nvuillam#176
nvuillam
pushed a commit
that referenced
this issue
Dec 18, 2023
* fix: file end of line character changes Maintain the current predominant end of line character for files when making edits. This changes editing to use the standard TextEdit insert and replace creation methods to reduce complexity and overhead. This only handles Unix '\n' and Windows '\r\n' line endings, not pre MacOSX Mac '\r' as CodeNar doesn't appear to support that line ending. Fix callback handling in tests, adding missing await and reject handling. Validate each file result in folder lint test instead of total. Use option chaining and early return in getUpdatedSource to improve readability. Remove use of deprecated isNullOrUndefined. Fixes #176 * ci: disable mega linter commits to forks Disable mega linter generation of commits to repo forks as this will generally fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The end of line characters are altered by fixes if they aren't the OS native line endings.
The current line endings should be maintained instead of assuming that the user wants the current OS default.
The text was updated successfully, but these errors were encountered: