From d8d8eb91e1a4724ab7413b4a82ab85d2e04bf66d Mon Sep 17 00:00:00 2001 From: Michael Curran Date: Tue, 10 Sep 2024 14:19:50 +1000 Subject: [PATCH] sconstruct: correctly detect the language of xliff files when trying to skip English (#17143) Summary of the issue: The NVDA build system creates html from markdown files. For any language other than English, these markdown files should be themselves generated from xliff files. However, a rather strange and incorrect line of code caused this to also happen for English, as the line was not correctly detecting the language. Description of user facing changes English user documentation in alpha builds should be based on the very latest markdown files, rather than the last beta from the previous release. --- sconstruct | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sconstruct b/sconstruct index 0b9c6a401b2..8bbf1708f6c 100755 --- a/sconstruct +++ b/sconstruct @@ -335,7 +335,7 @@ numberedHeadingsStyle = os.path.join(userDocsDir.path, "numberedHeadings.css") # Create Non-english md files in user_docs from localized xliff and English skel files for xliffFile in env.Glob(os.path.join(userDocsDir.path, "*", "*.xliff")): - lang = os.path.basename(xliffFile.path).split(".")[0] + lang = os.path.split(os.path.dirname(xliffFile.path))[-1] if lang == "en": continue mdFile = os.path.splitext(xliffFile.path)[0] + ".md"