From 5b5d605517d8f78aff8e566f23ab06482c0321f9 Mon Sep 17 00:00:00 2001 From: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com> Date: Tue, 21 Jan 2025 12:00:36 +1100 Subject: [PATCH] Unbind apps volume gestures and reflect that they're unbound in the change log --- source/globalCommands.py | 3 --- user_docs/en/changes.md | 6 ++---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/source/globalCommands.py b/source/globalCommands.py index 9c22287a3c5..87a58c3a94c 100755 --- a/source/globalCommands.py +++ b/source/globalCommands.py @@ -4851,7 +4851,6 @@ def script_cycleSoundSplit(self, gesture: "inputCore.InputGesture") -> None: "Increases the volume of other applications", ), category=SCRCAT_AUDIO, - gesture="kb:NVDA+alt+pageUp", ) def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None: appsVolume._adjustAppsVolume(5) @@ -4862,7 +4861,6 @@ def script_increaseApplicationsVolume(self, gesture: "inputCore.InputGesture") - "Decreases the volume of other applications", ), category=SCRCAT_AUDIO, - gesture="kb:NVDA+alt+pageDown", ) def script_decreaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -> None: appsVolume._adjustAppsVolume(-5) @@ -4883,7 +4881,6 @@ def script_toggleApplicationsVolumeAdjuster(self, gesture: "inputCore.InputGestu "Mutes or unmutes other applications", ), category=SCRCAT_AUDIO, - gesture="kb:NVDA+alt+delete", ) def script_toggleApplicationsMute(self, gesture: "inputCore.InputGesture") -> None: appsVolume._toggleAppsVolumeMute() diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index 1d701a88119..7bef08c69d4 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -9,11 +9,9 @@ * Support for math in PDFs has been added. This works for formulas with associated MathML, such as some files generated by newer versions of TeX/LaTeX. Currently this is only supported in Foxit Reader & Foxit Editor. (#9288, @NSoiffer) -* Commands to adjust the volume of other applications besides NVDA have been added. +* The ability to adjust the volume of other applications besides NVDA has been added. To use this feature, "allow NVDA to control the volume of other applications" must be enabled in the audio settings panel. (#16052, @mltony, @codeofdusk) - * `NVDA+alt+pageUp`: Increase the volume of all other applications. - * `NVDA+alt+pageDown`: Decrease the volume of all other applications. - * `NVDA+alt+delete`: Mute the volume of all other applications. + * Added new unassigned gestures to increase, decrease and mute the volume of all other applications. * When editing in Microsoft PowerPoint text boxes, you can now move per sentence with `alt+upArrow`/`alt+downArrow`. (#17015, @LeonarddeR) * In Mozilla Firefox, NVDA will report the highlighted text when a URL containing a text fragment is visited. (#16910, @jcsteh) * NVDA can now report when a link destination points to the current page. (#141, @LeonarddeR, @nvdaes)