Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence diagram's exit arrow points to the right #379

Open
EvitanRelta opened this issue Apr 15, 2023 · 3 comments
Open

Sequence diagram's exit arrow points to the right #379

EvitanRelta opened this issue Apr 15, 2023 · 3 comments

Comments

@EvitanRelta
Copy link

EvitanRelta commented Apr 15, 2023

One of our reported bug states that our sequence diagram's last arrow set user input to "add t/tag1" should point to the left (ie. where the entry arrow comes from). Is he correct? Or is exiting on the right ok?

image.png

@toh-xinyi
Copy link

toh-xinyi commented Apr 15, 2023

I'm not entirely sure, but I think the tester would be right in this case as pointing to the right would make it seem like the sequence diagram has not ended. And since the invocation comes from the left, returning towards that direction would make the most sense. Like the following diagram taken from the textbook:
image

@EvitanRelta
Copy link
Author

alright. What should the severity be for this tho?
Is it very low, as its cosmetic and its unlikely for users to misunderstand?

@damithc
Copy link
Contributor

damithc commented Apr 16, 2023

alright. What should the severity be for this tho?
Is it very low, as its cosmetic and its unlikely for users to misunderstand?

The teaching team leaves the decision to you, but others are welcome to chime in their opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants