Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's time to make struct ndpi_flow_struct small again #2631

Open
IvanNardi opened this issue Nov 26, 2024 · 3 comments
Open

It's time to make struct ndpi_flow_struct small again #2631

IvanNardi opened this issue Nov 26, 2024 · 3 comments
Labels
enhancement

Comments

@IvanNardi
Copy link
Collaborator

On Jan 30, 2022 (see 5bb5bec)

nDPI Memory statistics:
	Flow Memory (per flow):  688 B

Now

nDPI Memory statistics:
	Flow Memory (per flow):  1.16 KB
@0xA50C1A1
Copy link
Contributor

Is it possible to move protocol-specific stuff out of struct ndpi_flow_struct into something else and leave something like void* protocol_data pointing to a protocol-specific stuff? Well, I dunno, probably it's not the best solution.

@utoni
Copy link
Collaborator

utoni commented Dec 2, 2024

IMHO most of the L7 protocol stuff is already a union.

@utoni
Copy link
Collaborator

utoni commented Dec 3, 2024

It could be worth checking if the struct members especially arrays could be reduced or removed i.e. host_server_name requires 80 bytes per flow, but from my experience, I think that that the array size is a waste of memory most of the times.

@IvanNardi IvanNardi mentioned this issue Dec 18, 2024
Open
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Jan 31, 2025
@IvanNardi
Preliminary work to rework struct ndpi_flow_struct
86666ee 
No significant changes:
 * Move around some fields to avoid holes in the structures.
 * Some fields are about protocols based only on TCP.
 * Remove some unused (or set but never read) fields.

See ntop#2631
@IvanNardi IvanNardi mentioned this issue Jan 31, 2025
Merged
IvanNardi added a commit to IvanNardi/nDPI that referenced this issue Feb 4, 2025
@IvanNardi
Preliminary work to rework struct ndpi_flow_struct
6eff7db 
No significant changes:
 * Move around some fields to avoid holes in the structures.
 * Some fields are about protocols based only on TCP.
 * Remove some unused (or set but never read) fields.

See ntop#2631
IvanNardi added a commit that referenced this issue Feb 4, 2025
@IvanNardi
Preliminary work to rework struct ndpi_flow_struct (#2705)
07eb92f 
No significant changes:
 * Move around some fields to avoid holes in the structures.
 * Some fields are about protocols based only on TCP.
 * Remove some unused (or set but never read) fields.

See #2631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@utoni @IvanNardi @0xA50C1A1