Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Methods for Workflow #92

Open
mr-palindrome opened this issue Oct 8, 2023 · 5 comments
Open

Add Missing Methods for Workflow #92

mr-palindrome opened this issue Oct 8, 2023 · 5 comments
Assignees

Comments

@mr-palindrome
Copy link
Contributor

None of the workflow endpoints are implemented in the python-SDK.

I checked and variefied that none of the workflow APIs are implemented in python-SDK. The examples mentioned in the Novu documentations seems to be wrong.

Need verification from the maintainers on this. As the novu/constants.py (https://github.com/novuhq/novu-python/blob/main/novu/constants.py) doesn't has any /workflow/ endpoint constant.

image image
@mr-palindrome
Copy link
Contributor Author

@Cliftonz @unicodeveloper can you guys please have a look on this!

@jainpawan21
Copy link
Member

@mr-palindrome
We recently renamed Notification Templates to workflows.

Yes we need to create workflows endpoints (methods) as well end mark notification templates endpoints (methods) as deprecated

@mr-palindrome
Copy link
Contributor Author

@mr-palindrome We recently renamed Notification Templates to workflows.

Yes we need to create workflows endpoints (methods) as well end mark notification templates endpoints (methods) as deprecated

So can I work on this and start creating the workflow methods!

@sumitsaurabh927
Copy link

@mr-palindrome any updates?

@mr-palindrome
Copy link
Contributor Author

@mr-palindrome any updates?

Yeah the DTO for workflow methods has been completed.. need to add the methods and the test cases. I'll make an initial commit in the respective forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants