Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select is-dark is Missing States #384

Closed
HiKaylum opened this issue Dec 14, 2019 · 2 comments
Closed

Select is-dark is Missing States #384

HiKaylum opened this issue Dec 14, 2019 · 2 comments
Assignees
@HiKaylum
Labels
bug Something isn't working

Comments

@HiKaylum
Copy link
Contributor

Describe the bug
The select component is missing the states is-error, is-warning & is-success when is-dark.

To Reproduce

  1. Add
<div class="nes-select is-dark">
    <select required>
        <option value="" disabled selected hidden>Select...</option>
        <option value="0">To be</option>
        <option value="1">Not to be</option>
    </select>
</div>
  1. Try add a class is-error, is-warning or is-success

Expected behavior
Select should show select state when is-dark.

Screenshots
N/A

Environment:
N/A

Suggestion(s) for fixing this issue
N/A

Additional context
N/A
@guastallaigor guastallaigor added the bug Something isn't working label Dec 14, 2019
@HiKaylum
Copy link
Contributor Author

HiKaylum commented Dec 14, 2019 •
edited
Loading

Found the issue, have a fix will wait till #385 goes through.

HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Dec 16, 2019
@HiKaylum
fix(select): fixed select state styling
455c30d 
select when `is-dark` can now have `is-error`, `is-success` and `is-warning`

fix nostalgic-css#384
@HiKaylum HiKaylum mentioned this issue Dec 16, 2019
Closed
@HiKaylum
Copy link
Contributor Author

Reopening, Closed it and the PR due to confusion.

@HiKaylum HiKaylum reopened this Dec 22, 2019
HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Dec 22, 2019
@HiKaylum
fix(select): fixed select state styling
aba2609 
select when `is-dark` can now have `is-error`, `is-success` and `is-warning`

nostalgic-css#384
@HiKaylum HiKaylum mentioned this issue Dec 22, 2019
Merged
HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Dec 27, 2019
@HiKaylum
fix(select): fixed select state styling
6b6f68e 
select when `is-dark` can now have `is-error`, `is-success` and `is-warning`

nostalgic-css#384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HiKaylum HiKaylum

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): fixed select state styling HiKaylum/NES.css
2 participants
@HiKaylum @guastallaigor