Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: scroll to hashtag (#) for vitepress-plugin-inline-link-preview #157

Open
Ampernic opened this issue Apr 9, 2024 · 2 comments
Open

feature request: scroll to hashtag (#) for vitepress-plugin-inline-link-preview #157

Ampernic opened this issue Apr 9, 2024 · 2 comments
Assignees
@nekomeowww
Labels
pkg/inline-link-preview Related to @nolebase/vitepress-plugin-inline-link-preview upstream Blocked by or related to upstream dependencies
Milestone
2.1.0

Comments

@Ampernic
Copy link
Contributor

Ampernic commented Apr 9, 2024

Now if use inline-link-preview with bi-directional-links it render page preview of page from beginning.

Screencast.from.2024-04-09.15-14-04.mp4
@nekomeowww
Copy link
Member

How about try to use vitepress-plugin-highlight-targeted-heading for now.

Try these demo links, it doesn't scroll to the targeted heading, but blinks:

Let me see how scrolling got implemented on the VitePress's side, might have some issues.

@nekomeowww nekomeowww changed the title feature request: Hashtag (#) support in inline-link-preview feature request: scroll to hashtag (#) for vitepress-plugin-inline-link-preview Apr 10, 2024
@nekomeowww nekomeowww added this to the 2.0.0 milestone Apr 16, 2024
@nekomeowww
Copy link
Member

This is quite hard to debug. I will move this to 2.1.0 milestone.

@nekomeowww nekomeowww modified the milestones: 2.0.0, 2.1.0 May 5, 2024
@nekomeowww nekomeowww added upstream Blocked by or related to upstream dependencies pkg/inline-link-preview Related to @nolebase/vitepress-plugin-inline-link-preview labels May 5, 2024
@nekomeowww nekomeowww self-assigned this May 5, 2024
@Ampernic Ampernic mentioned this issue May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekomeowww nekomeowww

Labels
pkg/inline-link-preview Related to @nolebase/vitepress-plugin-inline-link-preview upstream Blocked by or related to upstream dependencies
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@nekomeowww @Ampernic