Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processors/awesome_lint: fail when 2 items have the same name: attribute value #141

Closed
nodiscc opened this issue Nov 19, 2024 · 2 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@nodiscc
Copy link
Owner

nodiscc commented Nov 19, 2024

awesome-selfhosted/awesome-selfhosted-data#966

@Rabenherz112
Copy link
Contributor

While working on #144, I also wanted to address this issue. However, I realized that the problem was essentially already resolved through #142, or that this issue at least seems now somewhat redundant.

Here's what I mean: when a user submits a new file to awesome-selfhosted as myawesomesoftware.yml with the name My Awesome Software, the check_filename_is_kebab_case_software_name function triggers an error if the filename doesn't follow the kebab-case format. It then suggests the correct filename. If the suggested filename already exists, it effectively prevents duplicates because the new file cannot overwrite or coexist with an existing one.

Additionally, if a user chooses a name that doesn’t match the expected kebab-case variant (e.g., My Awesome Software!), any function relying on saving names for duplicate detection would also fail to identify it as a duplicate.

@nodiscc
Copy link
Owner Author

nodiscc commented Jan 8, 2025

Yes, this is indirectly solved by 1a57644

@nodiscc nodiscc closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants