Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: small edits to create-release-proposal workflow #56540

Merged
merged 1 commit into from
Jan 11, 2025
Merged

tools: small edits to create-release-proposal workflow #56540

merged 1 commit into from
Jan 11, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 9, 2025

Those are basically nits, but here's a PR anyway:

  • Piping echo '{}' into jq is pure overhead, we can use --null-input/-n instead.
  • create-release.sh name is a bit misleading, it only creates a proposal, so IMO it makes sense to align with the workflow name.

@aduh95 aduh95 requested a review from a team as a code owner January 9, 2025 22:46
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jan 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 9, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64449/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 7409a1d into nodejs:main Jan 11, 2025
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7409a1d

@aduh95 aduh95 deleted the create-release-proposal branch January 11, 2025 23:27
targos pushed a commit that referenced this pull request Jan 13, 2025
@aduh95 @targos
tools: edit create-release-proposal workflow
d732852 
Small cleanup edits.

PR-URL: #56540
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@aduh95 @Ceres6
tools: edit create-release-proposal workflow
b0c3a1f 
Small cleanup edits.

PR-URL: nodejs#56540
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol juanarbol approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @jasnell @lpinca @richardlau @juanarbol @RafaelGSS @marco-ippolito