Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: enable SQL math functions #56447

Merged
merged 1 commit into from
Jan 5, 2025
Merged

sqlite: enable SQL math functions #56447

merged 1 commit into from
Jan 5, 2025
+10 −0

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 3, 2025

This commit enables SQLite math functions.

Fixes: #56435

@cjihrig
sqlite: enable SQL math functions
e736950 
This commit enables SQLite math functions.

Fixes: nodejs#56435
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Jan 3, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (98d4ebc) to head (e736950).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56447      +/-   ##
==========================================
+ Coverage   88.53%   88.55%   +0.01%     
==========================================
  Files         657      657              
  Lines      190741   190741              
  Branches    36607    36612       +5     
==========================================
+ Hits       168881   168902      +21     
+ Misses      15036    15020      -16     
+ Partials     6824     6819       -5

see 25 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64305/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64317/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64327/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64333/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 4, 2025 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64342/ 🟡

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jan 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 338d70b into nodejs:main Jan 5, 2025
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 338d70b

@TheOneTheOnlyJJ TheOneTheOnlyJJ mentioned this pull request Jan 5, 2025
Open
@cjihrig cjihrig deleted the sqlite-math branch January 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:sqlite: "VACUUM INTO" gives error "no such function: floor"
5 participants
@cjihrig @nodejs-github-bot @jasnell @lpinca @targos