-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progress-bar): setup basic #98
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: flakey5 <[email protected]>
Co-authored-by: flakey5 <[email protected]>
Co-authored-by: flakey5 <[email protected]>
@AugustinMauroy, any progress here? Would love to have this landed! |
I'll take time today to fix this pr. When a generator as ended the process still running because the progressbar did't ended correctly |
@ovflowd could you give last review ? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the progress bar should be for:
- Loader (progress of loading files)
- Parser (progress of parsing files)
- Top Level generator.mjs (progress of going through generators, instead of each file being generated)
Bump, @AugustinMauroy |
IMO there should be a way to disable the progress bar, like |
+1 would that be a |
BTW @AugustinMauroy wdyt about https://github.com/bombshell-dev/clack feels like a nicer way for us to design this and looks neat! |
I need to take a look before giving my opinion |
Okay first look of clack, This may be an alternative to ordering, but the package does not have a progress bar feature. But it does have a spinner, which doesn't really help you keep track of the process. |
Shouldn't it be the other way round? Shouldn't there be a flag displaying the progressbar? |
Well you can always render:
We don't necessarily need a progress bar, but a way to track that there's progress. |
I don't care either way, I just think there should be a toggle to disable/enable it. I don't care if it's toggle on or toggle off |
I think it should be showing progress by default and an option to not show progress. Otherwise it doesn't make any sense lol |
okay I'll try to do something like that: But note:
|
That is just an example file, you can simply paste that here :) |
BTW @AugustinMauroy is there any update here? |
okay I use clack now. I din't have tested yet |
@AugustinMauroy, can you test then, please? |
I can't test now main branch is break (with lasted commit on nodejs/node) |
Can you tell me? What exactly is failing? Can you share? |
|
Fixed. Feel free to rebase! |
Description
Adding a cool progress bar to know what is going on.
Validation
Run this command and see progress bar
npx api-docs-tooling -i "/path/to/node/doc/api/*.md" -t legacy-html -o /tmp/out
Related Issues
Close #58
Check List