New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused param #2

Open

mybigman opened this issue Oct 27, 2024 · 1 comment

Assignees

mybigman commented Oct 27, 2024

length is not used here?

func hash(input string, length int) (string, error) {
	return bufToBigInt(sha3.Sum512([]byte(input))).Text(36)[1:], nil
}

nlepage self-assigned this

Owner

nlepage commented Oct 28, 2024

Yes this parameter was originally copied from the JS version, and it has been since removed from the JS version, see paralleldrive/cuid2@54ef5f9#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
Overall, this Go version would need to be updated to match the latest JS version, and also documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment