Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve code]: firebase/function/src 配下のコードのコード規約制定 #108

Open
nkte8 opened this issue Apr 19, 2024 · 0 comments
Open

[Improve code]: firebase/function/src 配下のコードのコード規約制定 #108

nkte8 opened this issue Apr 19, 2024 · 0 comments
Labels
invalid This doesn't seem right Reminds Low Priority Issue

Comments

@nkte8
Copy link
Owner

nkte8 commented Apr 19, 2024 •
edited
Loading

Where and how it seems bad?

フロントエンド部分であるastro/*についてはコード規約が決定したが、バックエンドであるfirebaseおよびworkersについては決定されていない。

What it shoud become?

workersについては https://github.com/nkte8/skyshare/milestone/2 によって削除される可能性が高いため、skyshareの根幹であるOGPジェネレータ（削除される可能性が低い）firebase/function/src配下のコードについては明確に設定・対応した方が良い
@nkte8 nkte8 added invalid This doesn't seem right Reminds Low Priority Issue labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right Reminds Low Priority Issue
Projects
Skyshare Management Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkte8