Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Option for Volume Control on Sound Feed Back #30

Open
rbdej opened this issue Jul 9, 2019 · 6 comments
Open

Feature Request: Option for Volume Control on Sound Feed Back #30

rbdej opened this issue Jul 9, 2019 · 6 comments

Comments

@rbdej
Copy link

rbdej commented Jul 9, 2019

Hi, I like the app and have been using it for quite some time now (about 2 or 3 weeks) and I just realised that a Volume control for the Sound Feedback option could be a great addition.

Thank you so much for the great app :)

@niw
Copy link
Owner

niw commented Jul 22, 2019

@rbdej Let me think about this, that feature could be improved for sure.

@rbdej
Copy link
Author

rbdej commented Jul 25, 2019

Ok, thank you for responding back. Keep up the great work on the app :)

@wrabit
Copy link

wrabit commented Mar 24, 2020

Would be good to see this

@niw
Copy link
Owner

niw commented Mar 25, 2020

Here, 523bade, I made an experimental change to add volume control.

There is no user interface to change it for now. Therefore you need to use defaults(1) to control it like defaults write at.niw.HapticKey SoundEffectVolume -float 0.3.

Since only user interface currently HapticKey has is status item menu, which can provide very limited user interactions for changing preferences.
It was enough for the original features, but time by time, by adding more, it is getting difficult to add many preferences on it.

It may take while to add new preferences user interface so, I posted this patch for now.

@amkaplan
Copy link

Speaking as someone who doesn't code, I'm putting in a vote for a volume control if it's feasible, whenever it's feasible.

I can, however follow instructions, if someone is game to provide them.

Many thanks

@dylan-cm
Copy link

I just want to chime in a second this. Functionality that would be the bees knees would be as you slide you feel clicks as if the slider as little notches.

Love the work you've done so far. Cheers.

niw added a commit that referenced this issue Mar 8, 2021
No user interface for volume setting at this moment.
Use `defaults(1)` to change it.
```
defaults write at.niw.HapticKey SoundEffectVolume -float 0.3.
```

See also #30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants