Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovered features are not surfaced above surrounding features #14

Open
mz8i opened this issue Dec 15, 2021 · 3 comments
Open

Hovered features are not surfaced above surrounding features #14

mz8i opened this issue Dec 15, 2021 · 3 comments

Comments

@mz8i
Copy link
Contributor

mz8i commented Dec 15, 2021

When hovering over a map feature, e.g. a power line, the feature is highlighted but it's ordering in relation to neighbouring features stays the same. As a result, if there are any features that overlap with the highlighted one, part of the feature might not be visible when hovering

Other libraries like Leaflet have an option such as riseOnHover - need to investigate how to achieve this mechanism with Deck.GL

@tomalrussell
Copy link
Member

Is this closed after nismod/infra-risk-vis#35 or still an issue?

@mz8i
Copy link
Contributor Author

mz8i commented Feb 3, 2022

Separate issue, as the hover highlight relies on deck.gl's autoHighlight.

See example using power lines:

hovered:
Screenshot_20220203_184957

selected:
Screenshot_20220203_185104

Whether it's a priority is another topic!

@mz8i
Copy link
Contributor Author

mz8i commented Feb 3, 2022

With some more work, the new mechanism we're using for selection highlight could be used for hover highlight, too. This would eliminate the above problem.

But performance might be an issue then, as the selection layer needs to run some computation on all visible features, whenever the selected feature changes. If that had to happen every time the hovered feature changes, we could run into performance issues.
Conversely, the built in autoHighlight mechanism is much simpler to ensure performance

@tomalrussell tomalrussell transferred this issue from nismod/infra-risk-vis Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants