Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom tool, zoom menu items #21

Closed
1 of 3 tasks
cmeyer opened this issue Aug 17, 2017 · 6 comments
Closed
1 of 3 tasks

Add zoom tool, zoom menu items #21

cmeyer opened this issue Aug 17, 2017 · 6 comments
Assignees
Labels
audience - user affects users effort - few days a few days f - raster-image good first issue good for newcomers impact - medium has straightforward but non-obvious workaround reach - large affects many users weekly type - enhancement

Comments

@cmeyer
Copy link
Collaborator

cmeyer commented Aug 17, 2017

  • Select zoom tool with hot key
  • Zoom should occur around mouse click or mouse location when appropriate
  • Zoom menu items (in the View menu)

From Tracy:
For zooming in an out, we use "+", but then you are always zooming about the center. If we use the track wheel on the mouse, we could zoom about the cursor, and then you could zoom in on a particular feature.

From Niklas:
The best tracking devices, track balls often come without a scroll wheel, so making + and - move around the cursor would be better. There is a usability issue in Swift in that it doesn't actually know where the cursor is, but it should.

Tasks

Preview Give feedback
  1. effort - day f - displays f - raster-image impact - low reach - all skill - ui skill level - basic type - enhancement
    Tiomat85
@cmeyer cmeyer changed the title Add a zoom tool, zoom-in/out menu items when right clicking, regular menu items Add zoom tool, zoom menu items Aug 17, 2017
@cmeyer cmeyer modified the milestone: Offline Sep 12, 2017
@Brow71189
Copy link
Collaborator

Maybe both ideas should be implemented? But I definitely think Tracy's idea should, because this is what the mouse wheel does in most applications. Right now it moves images up/down in Swift, which is not very useful.
A nice side effect of zooming around the cursor is that you can use that to move the image around. Moving images is often a bit awkward in many programs, so using "zoom around the cursor" is a decent workaround.

Niklas' idea might be useful, too, but I 'm afraid that this can be confusing for users. Maybe we should just get trackballs with mouse wheels?

@ndellby
Copy link

ndellby commented Jun 9, 2020 via email

@Brow71189
Copy link
Collaborator

Brow71189 commented Jun 9, 2020 via email

@cmeyer cmeyer added the good first issue good for newcomers label Apr 17, 2021
@cmeyer cmeyer added stage - ready impact - medium has straightforward but non-obvious workaround audience - user affects users reach - large affects many users weekly effort - few days a few days and removed needs planning needs planning medium priority labels Feb 24, 2024
@cmeyer cmeyer added priority - medium automated priority tag and removed priority - medium automated priority tag stage - ready labels Feb 24, 2024
@cmeyer cmeyer added priority - high automated priority tag and removed priority - medium automated priority tag labels Mar 6, 2024
@cmeyer cmeyer added priority - medium automated priority tag and removed priority - high automated priority tag labels Mar 13, 2024
@cmeyer cmeyer added priority - medium automated priority tag and removed priority - medium automated priority tag labels Jul 25, 2024
@cmeyer cmeyer removed the priority - medium automated priority tag label Aug 8, 2024
@jamesrussell216
Copy link

jamesrussell216 commented Aug 14, 2024

PR for this currently is: #1073

However we're not currently happy with the two button concept so we're going to take another look at that first before moving this forward.

@jamesrussell216
Copy link

After discussion on this issue we've got a proposed revised spec that @Tiomat85 is going to code too...

  • One toolbar button for the zoom tool.
  • Left-click to zoom in, modifier-left-click to zoom out, zooming around the mouse cursor position.
  • Keep the +/- functionality; that should zoom around the centre of the image
  • Leave the scroll wheel zooming functionality for now.
  • Leave the left-click and drag to zooming functionality for now.

@Ion-e
Copy link

Ion-e commented Oct 9, 2024

Implemented correctly, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience - user affects users effort - few days a few days f - raster-image good first issue good for newcomers impact - medium has straightforward but non-obvious workaround reach - large affects many users weekly type - enhancement
Projects
None yet
Development

No branches or pull requests

7 participants