Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "noise cache" to further optimize view modes #46

Open
Tracked by #44
cmeyer opened this issue Aug 8, 2024 · 0 comments
Open
Tracked by #44

Add a "noise cache" to further optimize view modes #46

cmeyer opened this issue Aug 8, 2024 · 0 comments
Labels
audience - developer affects internal development or blocks another issue effort - day a day or less good first issue good for newcomers impact - high has difficult or onerous workaround reach - small affects a few users weekly

Comments

@cmeyer
Copy link
Contributor

cmeyer commented Aug 8, 2024

Added: What about cycling through 17 (or another number unlikely to be a factor of our most common acquisition dimensions) noise images? This would involve using some sort of cache keyed on the data shape and also including some mechanism to garbage collect noise that hadn't been used in a while? This can be done as another PR.

For the cycling cache idea, what is the specific requirement or use case it is trying to achieve? The changing from Poisson to Gaussian to turn the performance to O(1) is pretty self-explanatory.

Real acquisition can happen as fast as ~1ms, so 80ms for noise (better than 250ms for noise!) is an improvement, but still not fast enough for the simulator to run into the same performance bottlenecks as real acquisition. The goal is to have the noise not add more than a few ms per image. The maximum view rate target is around 50 fps or 20ms per frame. So something under 50ms, preferably closer to 20ms, would be good rate for the simulator. As a workaround, I can just disable noise completely in cases where I need to do performance testing - so this issue is generally a low priority task; but it might be nice to have eventually.

@cmeyer cmeyer added effort - day a day or less good first issue good for newcomers impact - high has difficult or onerous workaround reach - small affects a few users weekly audience - developer affects internal development or blocks another issue labels Aug 8, 2024
@cmeyer cmeyer changed the title Add a "noise cache" to further optimize view modes (see below) Add a "noise cache" to further optimize view modes Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience - developer affects internal development or blocks another issue effort - day a day or less good first issue good for newcomers impact - high has difficult or onerous workaround reach - small affects a few users weekly
Projects
None yet
Development

No branches or pull requests

1 participant