Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate multi-acquire special cases in acquisition pipeline #177

Open
4 of 9 tasks
cmeyer opened this issue Feb 23, 2024 · 1 comment
Open
4 of 9 tasks

Eliminate multi-acquire special cases in acquisition pipeline #177

cmeyer opened this issue Feb 23, 2024 · 1 comment
Labels
audience - developer affects internal development or blocks another issue effort - few days a few days impact - high has difficult or onerous workaround reach - small affects a few users weekly

Comments

@cmeyer
Copy link
Collaborator

cmeyer commented Feb 23, 2024

The special cases are mainly that the data items are updated in the ScanDataChannel and CameraDataChannel classes rather than the standard acquisition pipeline channels. This is problematic because it prevents separating the acquisition loop from the processing loops in the acquisition pipeline. The integrated acquisition loop and processing loop makes the acquisition loop unnecessarily difficult to implement/maintain and is a direct blocker of other issues.

One approach is to eliminate multi-acquire by providing all capabilities using other acquisition techniques. One of the capabilities is to calibrate resulting data in e/eV/s (see tasklist below).

Tasks

Preview Give feedback
  1. 6 of 9
    audience - user
  2. 1 of 7
    audience - user
  3. audience - developer
  4. 2 of 2
    audience - user
  5. audience - user
  6. audience - user
@cmeyer cmeyer added effort - month a month or less impact - high has difficult or onerous workaround stage - waiting reach - small affects a few users weekly audience - developer affects internal development or blocks another issue labels Feb 23, 2024
@cmeyer cmeyer added the priority - very high automated priority tag label Mar 14, 2024
@cmeyer
Copy link
Collaborator Author

cmeyer commented Mar 15, 2024

Comments from email Jan 17 2024.

  • the ability to automatically display composite line plot (multiEELSSpectra) could be added first as a manual post-acquisition step initially; then automatically when UI for post-acquisition steps is added
  • virtual detectors are available in the "Spectrum Imaging / 4d Scan Acquisition" panel, we would lose the ability (temporarily) to do multiple sequences of SI's automatically with virtual detectors
  • multiple sequences of SI's could still be done without virtual detectors using the "Acquisition Panel" right now
  • "auto dark subtraction" feature probably is not functional right now; probably isn't used; and would be dropped until someone complains
  • we would lose the ability (temporarily) to do automatic summing; Andreas contends this isn't useful without alignment; could still be done with a post-processing manual step
  • apply shift to each "frame" (actually applied to each step in the mult-acquire sequence I think) is still available as 1D ramp; lose the ability to use with virtual detectors (again, temporarily)

@cmeyer cmeyer added effort - week a week or less impact - high has difficult or onerous workaround effort - few days a few days and removed effort - month a month or less impact - high has difficult or onerous workaround priority - very high automated priority tag effort - week a week or less labels Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience - developer affects internal development or blocks another issue effort - few days a few days impact - high has difficult or onerous workaround reach - small affects a few users weekly
Projects
None yet
Development

No branches or pull requests

1 participant