Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF_DF_List_pu still has column names Gen_MW, Gen_MVar, Load_MW, Load_MVar despite being in pu values #5

Open
Realife-Brahmin opened this issue Jun 1, 2023 · 0 comments
Assignees

Comments

@Realife-Brahmin
Copy link
Collaborator

Realife-Brahmin commented Jun 1, 2023

While I do like my column names to be the same in both CDF_DF_List and CDF_DF_List_pu, using an explicit column name like Gen_MW even when one is actually getting a pu value (if extracted from CDF_DF_List_pu) might cause a little confusion.

There are at least three ways I can think of on how to deal with it:

  • Way 1: Don't Care + Didn't Ask. Mark this Issue as resolved anyway. The developer/user will have to deal with the fact that Gen_MW might mean different things depending on whether the value was extracted from CDF_DF_List or CDF_DF_List_pu.

  • Way 2: Change the column names in CDF_DF_List_pu to Gen_P_pu, Gen_Q_pu or something similar to clearly distinguish this from the actual values. The user will still have to know that the previous column names like Gen_MW cannot be invoked from CDF_DF_List_pu, and similarly Gen_P_pu cannot be invoked from CDF_DF_List.

  • Way 3: Keep the column names same in both cases, without explicitly specifying whether the values are in MW or pu. User will have to be careful whether they are extracting the MW value or the pu value.

Note: I use simple column names like PG, PL, QG and QL, if you're looking for inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants