From 2d40cdf2dde4b320f39b65b46815fe10e3c319d4 Mon Sep 17 00:00:00 2001 From: Dieter Baron Date: Wed, 8 Jan 2025 13:34:31 +0100 Subject: [PATCH] Fix fixdats with complete-games-only. --- regress/fixdat-missing-both.fixdat | 15 +++++++++++++++ regress/fixdat-missing-complete-only.vtest | 10 ++++++++++ src/check_game_files.cc | 2 +- 3 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 regress/fixdat-missing-both.fixdat create mode 100644 regress/fixdat-missing-complete-only.vtest diff --git a/regress/fixdat-missing-both.fixdat b/regress/fixdat-missing-both.fixdat new file mode 100644 index 00000000..e8e0387f --- /dev/null +++ b/regress/fixdat-missing-both.fixdat @@ -0,0 +1,15 @@ + + + +
+ Fixdat for ckmame test db (1) + Fixdat by ckmame + 0000-00-00 00:00:00 + automatically generated +
+ + clone-8 + + + +
diff --git a/regress/fixdat-missing-complete-only.vtest b/regress/fixdat-missing-complete-only.vtest new file mode 100644 index 00000000..44d1e856 --- /dev/null +++ b/regress/fixdat-missing-complete-only.vtest @@ -0,0 +1,10 @@ +description test all games, one rom missing, create fixdat +features HAVE_LIBXML2 +return 0 +arguments --no-status-db --complete-games-only -Fvc -D ../mamedb-lost-parent-ok.db --create-fixdat +file "fixdat_ckmame test db (1).dat" {} fixdat-missing-both.fixdat +directory roms <> +stdout +In game clone-8: +game clone-8 : not a single file found +end-of-inline-data diff --git a/src/check_game_files.cc b/src/check_game_files.cc index ed801c33..113cabb5 100644 --- a/src/check_game_files.cc +++ b/src/check_game_files.cc @@ -107,7 +107,7 @@ void check_game_files(Game* game, filetype_t filetype, GameArchives* archives, R if (rom.where == FILE_INGAME && match->quality == Match::MISSING && rom.hashes.size > 0 && !rom.hashes.empty() && rom.status != Rom::NO_DUMP) { - if (configuration.complete_games_only) { + if (configuration.complete_games_only && !configuration.create_fixdat) { match->quality = Match::UNCHECKED; if (missing_roms) { continue;