Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate conditions to trigger action only when overall result changes #878

Open
3 tasks done
maricn opened this issue Jan 23, 2025 · 0 comments
Open
3 tasks done

Comments

@maricn
Copy link

maricn commented Jan 23, 2025

Checklist

  • I checked for similar existing requests (both open and closed) before posting.
  • My request is generic, other users may benefit from it too.
  • I will participate in further discussion about this feature and can test it (if requested) once it's done.

Proposal

At the moment Re-evaluate Conditions will trigger action if any of the individual conditions in the multiple condition schedule change state.

I would be happy to have the evaluation not triggering the action unless the total result of all the conditions (after applying AND or OR operations) is changed.

My proposal is

  1. to change the behaviour (breaking backward compatibility) and document it or
  2. to introduce a config checkbox to toggle whether individual condition change should trigger action (too convoluted in a single view, could be moved to the component config)
  3. to allow a new type of complex condition evaluation also involving combining AND and OR operations
  4. idk?

Additional info

For example see my config here:

Image

and

Image

What happened today (and not the first time) is:

  1. I am home, person B is not. I manually lower the temperature at 01:05
  2. Person B arrives at 01:09, causing the revaluation to happen. Result of conditions was true OR false = true, and after reevaluation becomes true OR true = true. The reevaluation triggers the temperature change to 21 degrees.
  3. I notice the change and again lower the temperature at 01:17. No change in conditions.
  4. I leave home at 02:48, the reevaluation happens again, true OR true = true becoming false OR true = true, again triggering the action, raising the temperature to 21 as per the schedule.
  5. I finally get back home at 03:29 and upon finding the scheduler triggered as I was leaving, decide to open this ticket.

Image

What I would like is that the fact one of us is coming and leaving home - doesn’t cause the scheduler to trigger the action when "Any" condition setting is selected. Similarly for "All" setting, if the result of evaluating conditions doesn't change (at least one false remains at least one false), so shouldn't the scheduler trigger action.

@maricn maricn changed the title Re-evaluate conditions should trigger action only when overall result changes Re-evaluate conditions to trigger action only when overall result changes Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant