Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scheduling valve domain entities #819

Closed
3 tasks done
marcjay opened this issue Jun 2, 2024 · 5 comments
Closed
3 tasks done

Add support for scheduling valve domain entities #819

marcjay opened this issue Jun 2, 2024 · 5 comments

Comments

@marcjay
Copy link

marcjay commented Jun 2, 2024

Checklist

  • I checked for similar existing requests (both open and closed) before posting.
  • My request is generic, other users may benefit from it too.
  • I will participate in further discussion about this feature and can test it (if requested) once it's done.

Proposal

I've got some valve entities that I'd love to create a schedule for, but can see that the domain is not within the currently supported list.

Would you accept a PR that added support for this relatively new domain?

I'm aware of #808 (comment) so if it's not a good time for a PR that's no problem.

Additional info

Proposing to add the new domain, using the existing domains (e.g. cover) as a reference. Adding translations where able.

Copy link

github-actions bot commented Jul 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 3, 2024
@marcjay
Copy link
Author

marcjay commented Jul 3, 2024

Do you have any thoughts on this @nielsfaber ? Thanks

@github-actions github-actions bot removed the Stale label Jul 4, 2024
Copy link

github-actions bot commented Aug 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 3, 2024
@marcjay
Copy link
Author

marcjay commented Aug 3, 2024

One last attempt on this before it gets auto-closed. cc: @nielsfaber

@github-actions github-actions bot removed the Stale label Aug 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant